search

trummerjo / pvr.zattoo

Initial Comit
15 stars 9 forks source link

Add missing content to addon.xml.in and add translations #12

Closed rbuehlma closed 7 years ago

rbuehlma commented 7 years ago

I removed the license text from all header files as now the license.txt (GPLv2) is included. Is that ok or should we keep the license in the headers?

trummerjo commented 7 years ago

Sorry I have a lot of stuff to do at the moment. My first guess would be to keep the licence headers in these files because i actually copied them from another kodi plugin (Changed a few things if i remember correctly.)

rbuehlma commented 7 years ago

No hurry :) All the removed licenses are GPL2 as well. I'll ask ksooo in your PR he can give a hint.

ksooo commented 7 years ago

I'm not a lawer, but imo, if a file was (originally) copied, then the header must not be removed.

rbuehlma commented 7 years ago

I re-added the licenses (i.e. removed the commit)... Love changing the history ;)

rbuehlma commented 7 years ago

Thanks ksooo, I did fix the translations

Hedda commented 7 years ago

Will this pull request be merged?

And will then this repository be submitted/moved upstream to https://github.com/kodi-pvr ?

And binary releases of pvr.zattoo added to https://github.com/xbmc/repo-binary-addons ?

Asking as I did pull request #13

Hedda commented 7 years ago

@rbuehlma Please also see related pull request #14