trummerschlunk / master_me

automatic mastering plugin for live streaming, podcasts and internet radio.
GNU General Public License v3.0
550 stars 22 forks source link

GUI: ideas and sketches #23

Closed trummerschlunk closed 2 years ago

trummerschlunk commented 2 years ago

so this is how it will probably look like. Not the comic style though ;) soundsgood gui sketch easy 01 excalidraw

soundsgood gui sketch expert 01 excalidraw

magnetophon commented 2 years ago

Looks great.

In the current faust generated gui, I am missing the spatial relation of the MB compressor. The above configuration is the only one that makes sense: low bands left, high bands right, matching parameters next to each other. That is how I originally wrote it.

magnetophon commented 2 years ago

Where will you display the GR? I find it invaluable to see all the meters as I tweak, since most controls affect all meters: when you do less GR in one compressor, the others will often have to do more, and vise versa.

trummerschlunk commented 2 years ago

I was just too lazy for the meters yet. They will be in the corresponding block.

trummerschlunk commented 2 years ago

soundsgood gui sketch expert04 excalidraw

It's a lot of parameters, but I guess this way it could fit. With the colors, I am not quite sure yet.

How do you like it?

falkTX commented 2 years ago

fitting everything is a single view is nice, though it does get quite compact then. what about arrows to indicate the flow/order of the processing?

perhaps better to have the sliders and widget controls on the left, and labels on the right. it is more commonplace for it to be like that.

trummerschlunk commented 2 years ago

soundsgood gui sketch expert05 excalidraw

Arrows are nice.

trummerschlunk commented 2 years ago

yeah, labels on the right of sliders might be nice

magnetophon commented 2 years ago

fitting everything is a single view is nice, though it does get quite compact then.

You could save some space in the MB-comp by using just one label, in the middle of the two sliders.

trummerschlunk commented 2 years ago

I am really worried if this is getting too big for one page. It would be awesome.

Please let me know if it does not work...

trummerschlunk commented 2 years ago

fitting everything is a single view is nice, though it does get quite compact then.

You could save some space in the MB-comp by using just one label, in the middle of the two sliders.

good idea!

trummerschlunk commented 2 years ago

I forgot: the sliders should be double-clickable to enter precise values.

magnetophon commented 2 years ago

Also, we can save some space by:

trummerschlunk commented 2 years ago

how do you like the big 'easy' components?

trummerschlunk commented 2 years ago

soundsgood gui sketch expert06 excalidraw

magnetophon commented 2 years ago

A more general question: it seems to me the DSP is not finished yet; you still need to decide wich blocks will be in the final product, and which parameters of wich blocks are exposed (for example, I would expose the knee parameter of all compressors and limiters.

Finally, also related to how the gui will look, sice it depicts the flow: shouldn't the correlation correction be after all the MS processing? Maybe I misunderstood what it's supposed to do, but from the name and a quick glance at the code it seems to correct the stereo width. Why correct it first and then mess with the MS afterwards?

magnetophon commented 2 years ago

With the colors, I am not quite sure yet.

I prefer the colors that @falkTX chose here.

trummerschlunk commented 2 years ago

A more general question: it seems to me the DSP is not finished yet; you still need to decide wich blocks will be in the final product, and which parameters of wich blocks are exposed (for example, I would expose the knee parameter of all compressors and limiters.

Finally, also related to how the gui will look, sice it depicts the flow: shouldn't the correlation correction be after all the MS processing? Maybe I misunderstood what it's supposed to do, but from the name and a quick glance at the code it seems to correct the stereo width. Why correct it first and then mess with the MS afterwards?

almost finished ;)

the correlation correction is a feature request from the ccc voc team. If a signal is mono, but not in the middle, it is put in the middle. This comes from some situations, where people will stream with two mics, not putting them both in the middle, but left and right.

trummerschlunk commented 2 years ago

With the colors, I am not quite sure yet.

I prefer the colors that @falkTX chose here.

I like it too... A bit too 'native-instruments', maybe? This is probably an easy tweak in the end...

trummerschlunk commented 2 years ago

soundsgood gui sketch expert07 excalidraw

knee added for 'limiter' stereo control changed

I am pretty sure, that these are all the parameters and the signal flow is fine.

trummerschlunk commented 2 years ago

The only thing I don't know how to solve: the ms-multiband-comp gain reduction meters have no numeric readout yet. And we need it.

trummerschlunk commented 2 years ago

@falkTX All this exercise is more about coming clean with the final parameters and signal flow. If you have other ideas, go for it!

trummerschlunk commented 2 years ago
image

I really like the intuitive aspect of this. If input-lufs, target, output lufs have the same scale. Maybe it's better than my previous 'big-meters'. I just don't know where to put the labels...

magnetophon commented 2 years ago

knee added for 'limiter'

Why not expose the knee for the brickwall as well?

Also, since the limiter has a strength parameter, it stops being a limiter and becomes a compressor, right? Since all compressors have knee, and all compressors have MS, those are not that helpful in the name of the block, imho.

I propose the following names:

Related issue: https://github.com/trummerschlunk/soundsgood/issues/25

magnetophon commented 2 years ago

The only thing I don't know how to solve: the ms-multiband-comp gain reduction meters have no numeric readout yet. And we need it.

Just add [unit:dB] and faust will take care of it. Also for the leveler_meter_gain.

trummerschlunk commented 2 years ago

The only thing I don't know how to solve: the ms-multiband-comp gain reduction meters have no numeric readout yet. And we need it.

Just add [unit:dB] and faust will take care of it. Also for the leveler_meter_gain.

This was meant GUI-wise. No space... ;)

x42 commented 2 years ago

May I suggest to take inspiration from the Harrison Mixbus master-strip? In particular the bargraph stereo-correlation meter: image

Oh, and I do have a faible for needle-meters. Especially is space is limited they're a lot more readable.

x42 commented 2 years ago

PS. I do like the arrows showing the signal flow!

falkTX commented 2 years ago

do the presets need to be there in advanced mode? the simple/easy mode is lacking things to show if we want to have GUI size the same as the advanced one, so one idea is to have the preset buttons visible only on the easy mode.

trummerschlunk commented 2 years ago

not really... I think we can put them in 'simple-mode' only. Then it's kind of a 'preset-mode'.

falkTX commented 2 years ago

alright, then easy mode can just have some big noob buttons :D

trummerschlunk commented 2 years ago

plus the welcome-text, I'll write soon. perfect!

trummerschlunk commented 2 years ago

closing this in favor of https://github.com/trummerschlunk/soundsgood/issues/40