trummerschlunk / master_me

automatic mastering plugin for live streaming, podcasts and internet radio.
GNU General Public License v3.0
550 stars 22 forks source link

GUI related issues and ideas #40

Closed trummerschlunk closed 2 years ago

trummerschlunk commented 2 years ago
falkTX commented 2 years ago

mb-ms-comp: name needs multiband reference. Let's make it 'Multiband MidSide Comp'. Hope it fits.

mb-ms-comp: put 'low' and 'high' below the paramters, so parameters are in horizontal line with kneecomp and limiter.

these 2 are done, please check latest build

mb-ms-comp: rename 'output-gain' to 'makeup'

should be done on faust dsp file side, you should be able to change and try it out

falkTX commented 2 years ago

please update the first post for adding new items.

falkTX commented 2 years ago
  • target fader needs some label 'target'

  • all: separator before meters without 'Outputs:'

  • change plugin name to 'master_me'

these should be done with d833f8474293cf636013cee50d7f6eafae9b4602

on the mscomp meter labels, not sure where to place those, suggestions welcome. perhaps using the right-side space for it?

falkTX commented 2 years ago
  • gate meter missing

what meter is this? I dont see it exported.. maybe the "leveler_gate" one is misplaced?

trummerschlunk commented 2 years ago
  • gate meter missing

what meter is this? I dont see it exported.. maybe the "leveler_gate" one is misplaced?

dammit, it has none... I will investi-gate, harr harr

trummerschlunk commented 2 years ago

multiband midside compressor: the meters are in the wrong order. lowest frequency should be on the left.

trummerschlunk commented 2 years ago

on the mscomp meter labels, not sure where to place those, suggestions welcome. perhaps using the right-side space for it?

we could place 'brickwall' under 'limiter', make 'mb-ms-comp' wider and place numeric readout in the meters, which could then be wider.

falkTX commented 2 years ago

on the mscomp meter labels, not sure where to place those, suggestions welcome. perhaps using the right-side space for it?

we could place 'brickwall' under 'limiter', make 'mb-ms-comp' wider and place numeric readout in the meters, which could then be wider.

that was my intention, specially considering the still missing arrows

trummerschlunk commented 2 years ago

Good! Maybe not even arrows but 'connections'. Just a straight line, connecting the modules?

falkTX commented 2 years ago

how would we indicate the flow with a single line?

testing arrows.

image

too silly?

magnetophon commented 2 years ago

I just noticed that the EQ is in fact between the knee compressor and the MB comp. So unless we want to change the GUI layout or change the DSP, it might be better to leave out the arrows, as they might be confusing otherwise.

trummerschlunk commented 2 years ago

how would we indicate the flow with a single line?

testing arrows.

image

too silly?

maybe a bit smaller, darker?

trummerschlunk commented 2 years ago

I just noticed that the EQ is in fact between the knee compressor and the MB comp. So unless we want to change the GUI layout or change the DSP, it might be better to leave out the arrows, as they might be confusing otherwise.

my bad. EQ section is before the kneecomp.

falkTX commented 2 years ago

is anything incorrect on the UI positioning?

trummerschlunk commented 2 years ago

no, all correct

trummerschlunk commented 2 years ago

dammit, I am so sorry, @falkTX The EQ-module needs to be before the leveler. thanks @magnetophon for pointing me in this direction.

falkTX commented 2 years ago

ah just swapping the 2 then. quite ok to do.

falkTX commented 2 years ago

so this is correct now?

image

just needs the gate meter

trummerschlunk commented 2 years ago

yes. two more arrows? image

trummerschlunk commented 2 years ago

ah, you did them already :)

x42 commented 2 years ago

Maybe align the bottom row to the right?

Anyway, each of the sub-parts having a different width and height looks rather weird to my eye. Are the plans to clean this up?

falkTX commented 2 years ago

Anyway, each of the sub-parts having a different width and height looks rather weird to my eye. Are the plans to clean this up?

Got any ideas. If you run the latest build you can click on the plugin name to open the theme editor which has a widget list with some properties below it, allowing us to fiddle with position and sizes.

Making everything have the same height doesnt look to me tbh, tried it just now:

image

We could vertically align the groups perhaps?

falkTX commented 2 years ago
* mb-ms-comp: numeric readout or scale on the meters.

does this work?

image

falkTX commented 2 years ago

or maybe the other way around. from -3 in the center to 0 on the edges?

image

trummerschlunk commented 2 years ago

or maybe the other way around. from -3 in the center to 0 on the edges?

I really like this last one! But labels need to be swapped. 0dB in the middle and -3dB top and bottom.

Also, I think we can drop the numbers above the bands. Saving one row of space.

trummerschlunk commented 2 years ago

The gate meter becomes all black, when it reaches -70dB, when it should be all yellow.

falkTX commented 2 years ago

or maybe the other way around. from -3 in the center to 0 on the edges?

I really like this last one! But labels need to be swapped. 0dB in the middle and -3dB top and bottom.

if we make -3db on top and bottom and 0db in the middle, we cant really use the same style of metering where it flows from the middle to the edges, because typically these meters are in -3dB and slowly grow into 0dB. which means their meters flow from the edges into the middle.

falkTX commented 2 years ago

wait no, I am wrong. 0dB is the default and it slowly goes till -3dB. seems same issue as with the gate meter

falkTX commented 2 years ago

The gate meter becomes all black, when it reaches -70dB, when it should be all yellow.

fixed now too, along with the rest on this ticket.

please check and confirm (closing ticket if all good)