trumpimar / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Code Review Request: Copy updating methods from SendToDocs to separate classes. #205

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Mercurial clone with changes to be reviewed:

simmonmt-refactoring

Revisions to be pulled from that clone (or "all"):

all

Purpose of code changes on the clone:

These classes contain the methods which perform the actual document updates from
SendToDocs, as well as tests for same.  To minimize reviewer load, these
routines aren't actually removed from SendToDocs in this change.  Once this
change is in, a subsequent change will make SendToDocs use the routines
extracted here.

When reviewing my code changes, please focus on:

Original issue reported on code.google.com by simmonmt@google.com on 2 Nov 2010 at 10:52

GoogleCodeExporter commented 9 years ago
I'm looking at this.  I am not sure about the choice to not do the changes to 
the calling code in the same change but we can go forward like this.

FWIW I am writing a lot of comments on the code you did not write, but it seems 
like a good time to clean it up.

Original comment by sandordo...@google.com on 3 Nov 2010 at 2:09

GoogleCodeExporter commented 9 years ago

Original comment by sandordo...@google.com on 14 Jan 2011 at 12:43