Gingerbread compatibility

GoogleCodeExporter commented 9 years ago

I need to update the app to use/be compatible with whatever is new in 
Gingebread. Details will be discussed internally until GB is out, but I'm 
keeping this as a reminder.
Also marking as private just in case.

Original issue reported on code.google.com by rdama...@google.com on 17 Nov 2010 at 2:21

GoogleCodeExporter commented 9 years ago

One thing I've noticed so far:  the service notification icon has white border, 
which doesn't look nice, provided that the notification area now is in black.

Original comment by ba...@google.com on 17 Nov 2010 at 2:35

GoogleCodeExporter commented 9 years ago

Yup, that's one thing to fix.
I've sent a list of other things to the internal mailing list.

Original comment by rdama...@google.com on 17 Nov 2010 at 2:37

GoogleCodeExporter commented 9 years ago

Removing private tag now that GB is public :)

Original comment by rdama...@google.com on 7 Dec 2010 at 8:42

Removed labels: private

GoogleCodeExporter commented 9 years ago

Original comment by rdama...@google.com on 7 Dec 2010 at 8:42

Changed state: Started

GoogleCodeExporter commented 9 years ago

Please review first set of changes:
http://code.google.com/r/rdamazio-mytracks-staging1/source/list

Original comment by rdama...@google.com on 10 Dec 2010 at 4:43

Changed state: UnderReview

GoogleCodeExporter commented 9 years ago

Rodrigo I noticed an nice change in Gingerbread for committing preference 
changes.  Can you include this change in our code base:
http://code.google.com/p/zippy-android/source/browse/trunk/examples/SharedPrefer
encesCompat.java

Brad included a reference to it in his blog post here:
http://android-developers.blogspot.com/2010/12/new-gingerbread-api-strictmode.ht
ml

Original comment by sandordo...@google.com on 13 Dec 2010 at 6:09

GoogleCodeExporter commented 9 years ago

Yes I noticed that, but notice that Android preferences themselves don't use 
that yet (they crash in strict mode, actually).
Anyway, we can change our instances, except those that save information needed 
to recover from a crash.

Original comment by rdama...@google.com on 13 Dec 2010 at 6:57

GoogleCodeExporter commented 9 years ago

And btw, to use that we'll need a wrapper so that pre-GB devices continue to 
work.

Original comment by rdama...@google.com on 13 Dec 2010 at 6:58

GoogleCodeExporter commented 9 years ago

Look at the first link.  It is such a wrapper.

Original comment by sandordo...@google.com on 13 Dec 2010 at 7:03

GoogleCodeExporter commented 9 years ago

You may want to update PlatformAPI interface + implementations.

The problem with some wrappers is that that must not use directly new classes 
(as to avoid Linkage error). Instead, just use Class.find("...").

Original comment by ba...@google.com on 13 Dec 2010 at 7:05

GoogleCodeExporter commented 9 years ago

I don't like that wrapper - it uses reflection, which is probably slower than 
doing the synchronous write (no I didn't measure, I'm supposing).

This is not a case that needs to use new classes, just a new method.

Original comment by rdama...@google.com on 13 Dec 2010 at 7:46

GoogleCodeExporter commented 9 years ago

That's why I proposed PlatformAPIAdapter which uses reflection only at 
construction time.

You would provide a new method, e.g. commitPreferences, and implement it in a 
platform specific way.  For instance, check how I've implemented setForeground.

Original comment by ba...@google.com on 13 Dec 2010 at 7:50

GoogleCodeExporter commented 9 years ago

Done in 
http://code.google.com/r/rdamazio-mytracks-staging1/source/detail?r=42f08692abf0
ac863d1e202ebc9e02cb655e8eba

Please review so I can merge.

Original comment by rdama...@google.com on 24 Dec 2010 at 7:42

GoogleCodeExporter commented 9 years ago

Original comment by sandordo...@google.com on 5 Jan 2011 at 5:51

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I notice the comments about Gingerbread - for your info it does not work on my 
Android 2.3 phone.  Perhaps a new Android compatibility issue worth looking at?

Original comment by tonyjwhe...@gmail.com on 8 Jan 2011 at 12:56

GoogleCodeExporter commented 9 years ago

Can you provide more details on what you mean by "doesn't work"? What phone do 
you have, and what happens? If possible also provide logs from the failure.

As an additional note, the gingerbread changes done here haven't been released 
to Android Market yet, but it should be working even without those.

Original comment by rdama...@google.com on 10 Jan 2011 at 3:19

trumpimar / mytracks

Gingerbread compatibility #220