trumpimar / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Review request: Refactor SendToDocs #263

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Mercurial clone with changes to be reviewed:  simmonmt-refactor-sendtodocs

Revisions to be pulled from that clone (or "all"):

all

Purpose of code changes on the clone:

Refactoring SendToDocs; moving the methods which do the gdata magic into their 
own class so they're easier to test and so the higher-level code which calls 
them can be tested.

NOTES:
  - Sandor reviewed DocsHelper, DocsTagBuilder, tests for those, and the changes to GDataWrapper as part of 43134248c9 in simmonmt-refactor.  It may not be necessary to re-review them as part of this change.
  - This change could've been folded into simmonmt-refactor, but wasn't due to various problems I probably could've overcome.
  - I've intentionally left the logic in SendToDocs#uploadToDocs alone, and would rather not change it in this CL.  There's enough going on here as is -- I want this CL to be about moving the GData methods out of the way.

Original issue reported on code.google.com by simmonmt@google.com on 5 Jan 2011 at 10:30

GoogleCodeExporter commented 8 years ago
Reviewing.

Original comment by rdama...@google.com on 5 Jan 2011 at 10:34

GoogleCodeExporter commented 8 years ago
As Matthew commented, perhaps Sandor should be the one reviewing this, so 
assigning to him instead.

Original comment by rdama...@google.com on 5 Jan 2011 at 10:39

GoogleCodeExporter commented 8 years ago

Original comment by simmonmt@google.com on 6 Jan 2011 at 11:47

GoogleCodeExporter commented 8 years ago

Original comment by sandordo...@google.com on 10 Jan 2011 at 6:22