trungdong / prov

A Python library for W3C Provenance Data Model (PROV)
http://prov.readthedocs.io/
MIT License
120 stars 44 forks source link

visualisation of (undefined/external) agents and activities #118

Closed pohutukawa closed 6 years ago

pohutukawa commented 6 years ago

Agents are rendered in a pentagon/house shape, and activities as a rectangle. If now an agent/activity is not defined/declared within a PROV document, but is external (e.g. defined in a previous PROV document), then the dot graph is topographically still rendered correctly (with edges and the undeclared element rendered in grey), however the shape of the element is an oval (that of an entity).

I suppose that by the context (the type of an edge, e.g. through the wasAttributedTo or the wasGeneratedBy edges), the prov library may be able to declare the shape of the vertex for graph rendering with dot consistently.

Or is there something I'm missing, thus making the rendered graph and its behaviour correct in this context with undeclared vertices?

trungdong commented 6 years ago

Hi @pohutukawa,

Thank you for the suggestion. I have implemented it in the above commit in the dev branch. For example, the statement used(a1, e1, -) will generate the following: test

I'm planning to make a minor release shortly, which will include the above feature.

pohutukawa commented 6 years ago

BTW, works fine now. Would be good to get this merged into master with a service release.

kauriid-prov-asb