Assignment 1 review

[trungdq88]

I have finished assignment 1 (movie review application), please review, thank you! README file: https://github.com/trungdq88/learn-swift/tree/master/assignment-1 /cc @coderschoolreview

[coderschoolreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Excellent
• Visual Design: Excellent
• Usability: Excellent

I'm going to guess you're a Java programmer? Great job trying to encapsulate your software here. You might not have to build this much abstraction in future assignments.

One thing you can do is have required methods in protocols instead of doing this:

    func getApi() -> MovieApi {
        preconditionFailure("This method must be overridden")
    }

For more information, you can read the Apple Documentation.

• Code mostly in line with style guide. It's pretty readable, so good job.
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Nice work with the custom Movie cell and encapsulating it so that it can configure itself based on the movie instance.
• Nice work loading the images asynchronously and fading images.
• Note that your images are stretched in your Collection View. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• You should show the network failure, not only when the network is not reachable, but when there's a network error here:

        let task = session.dataTaskWithURL(url!) { (data: NSData?, response: NSURLResponse?, error: NSError?) -> Void in
            guard error == nil else {
                print("ERROR fetching movies", error)
                return
            }

Date truncated:

• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.

Last but not least - you should learn how to use the Asset Catalog for images: http://guides.codepath.com/ios/Adding-Image-Assets

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. Next time try to do all the optionals, like the Search Bar. =)