Assignment 2 review

[trungdq88]

Hi @coderschoolreview, thank you for review my assignment 1, I appreciate all your comments and improvement suggestions.

I have finished my assignment 2, this time I didn't manage to get the optional tasks done, I hope it would be alright. Maybe I will do some of the optional tasks on Sunday.

Link to assignment 2: https://github.com/trungdq88/learn-swift/tree/master/assignment-2

Again, thank you for contributing your time to teach this class. Have a good day.

/cc @coderschoolreview

[coderschoolreview]

Hi Trung

:+1: even though you didn't have enough time, thank you for still doing a good job. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

Great things that we see:

• Specifying Auto Layout constraints in your nibs.
• Encapsulating private view logic within your View files, e.g. BusinessCellView should only interact with external objects via the business property.
• Linking the filter model with the controls. If curious on a more complex implementation, see this popular form library for an alternative to implementing forms manually.
• Connecting the view controllers via the custom filter delegate. As you are already aware, this is a popular pattern for handling events between view controllers.
• Organizing app logic into clear/specific purpose classes.
• Love the personal touch on "Selected N categories" and "Sad. There is no result :("
• Excellent habit of adding comments in your code and keeping your code neat, following a good style guide where possible.

Some suggestions or areas for improvements:

• The search bar in Categories is cool! However, consider using case insensitive search though because I am trying to search for Africa in this screenshot:
• When search is full screen, I cannot go back to the Filters view without going back to the main Yelp home screen (Businesses) view first.
• For Search on the home screen, after clearly the search text, I cannot trigger a Search on empty text to view all (unfiltered) results.
• Your use of BusinessTableHandler and CategoryTableHandler is quite interesting. It is clean but it's not as straight forward for others to follow. We recommend using extension SearchViewController: UITableViewDelegate, UITableViewDataSource syntax instead.
• Your use of BusiessCellView.show(business) is interesting. A common way is to set private subviews in a didSet observer like this

var business: Business! {
    didSet {
        // set subviews here, using values from the business variable
    }
}

This was a challenging assignment, congrats on completing it. Hope you will continue to make time to practice new techniques and build great iOS apps.