trungdq88 / react-router-page-transition

Highly customizable page transition component for your React Router
https://trungdq88.github.io/react-router-page-transition
MIT License
542 stars 53 forks source link

Code snippets added to live demo #37

Closed 0000marcell closed 6 years ago

0000marcell commented 6 years ago

Showing the code for each transition in the live demo, maybe in the future adding a more detailed explanation about the transition.

trungdq88 commented 6 years ago

Hi, thanks for the PR. I'll have a look at this at weekend.

trungdq88 commented 6 years ago

Hi, thanks for the PR, I'm really appreciate your contribution but I'm afraid I can't merge this because:

image

Having code snippets in live demo sometimes can be useful, but in this case I cannot see the benefits worth to add in, sorry.

0000marcell commented 6 years ago

Sorry for the late replay I agree with your points about the overall look, but the page needs to be redesigned in order to solve this problem, maybe have a code link with the code, i still think that having the necessary code to implement the transition is important, most people use github on the desktop and usually they are looking for a quick solution, this is specially true with react since is a new technology and most people using it are new to programming in general, just the fact that you have to download the code or browse through github is a huge pain.

about the code being too long, that's where my other comments come in, maybe we could ship some transitions with the component or create a separate module with the transitions, so we could download the component and the transitions that we wanna use, these are just ideas, the overall goal is just to be more user friendly.