Add an option to url type to open the remote URL in a new web page

trungleduc / jupyter_app_launcher

A JupyterLab extension to create custom launcher entries.

https://jupyter-app-launcher.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

54 stars 12 forks source link

Closed imcovangent closed 1 year ago

imcovangent commented 1 year ago

Closely related to #27 I think it would be great if it is also possible to open remote URLs in a new webpage.

For some webpages it is much nicer to be able to open them in a new tab. Also, some pages are hard to embed in iFrame.

My use case: I want to be able to direct users to tutorial videos on YouTube.

I guess implementing this for the remote URL should be relatively straightforward. If you are open to it, I can make a PR for it.

trungleduc commented 1 year ago

Thank you for your suggestion and PR is welcome!

imcovangent commented 1 year ago

Great, see draft PR #38

Can you have a look at my implementation and let me know if you require anything before the PR can be completed?

If the implementation is agreed, then I will add an example and extend the documentation accordingly.

trungleduc commented 1 year ago

Closes as completed