trungleduc / jupyter_app_launcher

A JupyterLab extension to create custom launcher entries.
https://jupyter-app-launcher.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
53 stars 11 forks source link

Opening a notebook a second time overwrites existing file #58

Open andeplane opened 4 months ago

andeplane commented 4 months ago

It seems like there is logic in place to handle existing files so you get appended numbers to the file name. However, if I open https://trungleduc.github.io/jupyter_app_launcher/lab/index.html and do 1) Open Notebook Example, a new file Notebook example.ipynb is created 2) Modify the files with whatever 3) Open launcher again and choose Notebook Example again.

Now the changes from step 2 are lost. Would be nice if it rather opened Notebook example-2.ipynb instead (like the code seems to attempt to do).

trungleduc commented 4 months ago

Thanks for reporting the issue, I will take a look at it

andeplane commented 4 months ago

Lovely! Thanks for making a great plugin btw