search

trungn1992 / httplib2

Automatically exported from code.google.com/p/httplib2
0 stars 0 forks source link

timeout during conn.getresponse causes retry, doubling effective timeout #145

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.  I've changed the unit test (both python2 and python3 versions) in the 
attached patch to assert that the elapsed time is less than 2x the specified 
timeout - 1 second, and specify timeout as 2 seconds.  The test fails for me.

What version of the product are you using? On what operating system?

I'm testing against cf7232378fe3 on Ubuntu maverick x86_64, python2.6.6 and 
python3.1.2.

The behavior seems to have originally changed in 686c61b0d4e1, when the code 
changed to retry all socket.* errors.

I've attached a patch with what I think is a fix for both python2 and python3.

Original issue reported on code.google.com by aaron.s....@gmail.com on 27 Apr 2011 at 4:28

Attachments:

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision 2e8273f05605.

Original comment by joe.gregorio@gmail.com on 13 Jun 2011 at 5:09