Assignment week 1

[trungquangnguyen]

hi, this is my homework /cc @coderschoolreview

[trungquangnguyen]

i have some issues with, but I will continue update my codeat now

[coderschoolreview]

Hi @trungquangnguyen, thanks for your submission.

• Please do not change the Reamme template. Keep is as it it and just mark on the items you completed.
• It looks like you are missing one feature (network error) from the required user stories. We will need to have this completed and updated within 24hr from this point in order for you to receive credit for the assignment.

[trungquangnguyen]

Thanks for your reminded,I will keep it in mind and updateed as soon as

[coderschoolreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Excellent
• Visual Design: Good
• Usability: Good
• Overall: Excellent

Detailed Notes

• Good job using the nib file. However, we recommend to use the story board as later when you app getting bigger, story board can help you easily visualize the whole picture.
• Great clean code. Good job utilzing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• Nice work implementing the Movie model.
• Nice work with the custom Movie cell and encapsulating it so that it can configure itself based on the movie instance.
• Nice work loading the images asynchronously.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Your error message should be displayed if a network request fails and hidden again if it succeeds. You shouldn't use the UIAlertController, when user taps on OK, your HUD keeps spinning forever.
  • Nice job implementing a UIScrollView. UIScrollView is the parent class of UITableView.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• Not a big deal, but when you search and find no result, you should display No result

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work.

[trungquangnguyen]

\Thanks for your reviewed,I will keep it in mind and update it in next homework :