Assignment week 2

[trungquangnguyen]

hi, this is my homework /cc @coderschoolreview

[trungquangnguyen]

hi, I have some proplem with git, please review SUBMIT branch instead of master. thank you

[minhchau273]

Hi Quang,

It looks like you didn't complete all the required functionalities. You didn't implement the search feature with UISearchBar. You have to send a request to the API to get results when searching.

Your assignment needs to be updated within 24hrs in order for you to receive credit for this assignment.

Best, Chau

[trungquangnguyen]

Chau, i'm sory. I no excuses I've updated the code . Thanks for your remind (After tapping button Search in keyboard I sent a request to the API and get results. I hope this proplem not to you disappoint) /cc @minhchau273

[minhchau273]

:+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

• Functionality: Good
• Code Style: Average
• Visual Design: Average
• Usability: Good

Overall: Good

Detailed Notes

• Note that you should resolve all the Auto Layout constraint warnings in your nibs.
• Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
• Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
• You miss the trailing space to super view constraint so that the categoriesLabel is truncated in this cell.
• It would be better if you save the last user's choices in the filters page.
• A small issue is that I cannot hide the keyboard after searching.
• You should scroll the table view to the top after returning from the filters page.