search

trunk-io / plugins

Trunk.io plugins repo
https://docs.trunk.io
MIT License
126 stars 40 forks source link

What's the best apporach for dealing with 3rd party failurers? #632

Open maximveksler opened 10 months ago

maximveksler commented 10 months ago

I'm seeing terrascan failing, due to lack of support for a terraform feature I'm using. This causes trunk to report failure to run as well. What would be the suggest appraoch for dealing with the scenario where upstream has a known bug that is causing one of the plugins to fail?

I'd prefer trunk to understand that for 3rd praty plugin version X, it will fail on this fail and thus should be set to skip it up until the next version is released (after which resume scanning..)

Reference https://github.com/tenable/terrascan/issues/1642#issuecomment-1890972702

TylerJang27 commented 10 months ago

Hi @maximveksler! Thanks for flagging this. We don't have any mechanism for "temporarily skipping" linter runs like you've described, but there's a couple options I can recommend for you.

The most straightforward short-term fix would be to modify your .trunk/trunk.yaml to skip files that use the precondition syntax until the fix is released. You can read more about that syntax here, but an example would be:

lint:
  ignore:
    - linters: [terrascan]
       paths: [...] # glob paths supported

You also have the option of disabling terrascan entirely, or only for yourself locally in .trunk/user.yaml.

Let me know if that helps at all, happy to brainstorm other options that might work until a new fix is released.