search

trunkmaster / nextspace

NeXTSTEP-like desktop environment for Linux
https://trunkmaster.github.io
GNU General Public License v3.0
1.89k stars 69 forks source link

Distribution/release [for ARM]: Update libobjc2 to version 2.1.1 as soon as published [title updated] #329

Closed Letterus closed 5 months ago

Letterus commented 4 years ago

libobjc2 2.0 will not build for Linux ARM (armhf/arm64) until https://github.com/gnustep/libobjc2/commit/4cf4ad145cfcd8fd08f90157d851c2374ac32151, see https://github.com/gnustep/libobjc2/issues/164.

Please include that version for the next release. This is especially relevant for Debian Packaging when it comes to Raspbian, @pgeorgi.

trunkmaster commented 4 years ago

@Letterus thanks for info. I think it should be better to wait for new libobjc2 release.

Letterus commented 4 years ago

@trunkmaster There now is a new release of libobjc2, v2.1.

https://github.com/gnustep/libobjc2/releases/tag/v2.1

That release provides serious improvements for the ARM platform.

Would be great if you could update that dependency. Please take into account that libobjc2 now depends on submodules, so you either have to init those via git or load the dependencies as tarballs (see release notes).

trunkmaster commented 4 years ago

@Letterus thanks, I'll update dependencies after some testing of new libobjc2 version.

trunkmaster commented 4 years ago

@Letterus I've updated SPEC file to a new release. Check it out.

Letterus commented 4 years ago

Great, thank you!

@pgeorgi Would you mind adopting this update for the Debian packaging? That would be nice.

pgeorgi commented 4 years ago

@Letterus See #338

Letterus commented 4 years ago

@Letterus See #338

Arr. Great, really happy about that. Trying again to apply that on ARM soon. Thank you!

(Thank you for the documentation as well. I'm going to try to learn how this Debian packaging works. It works great on my system, so it must be great, but I did not really get it yet. ;-))

trunkmaster commented 4 years ago

@Letterus has this issue resolved?

Letterus commented 4 years ago

To be true: Not completely. It appeared that libobjc2 2.1 contains bug https://github.com/gnustep/libobjc2/issues/177 which was only fixed after the release of 2.1. For the Debian build this is currently fixed by a patch, but it might be that for the next release you will need to rely on the release of 2.1.1.

trunkmaster commented 4 years ago

@Letterus current libobjc2 2.1 builds successfully on x86_64. Is it true for ARM? If answer is "yes", switch to version 2.1.1 or 2.2 should be a separate issue. If - "no" please reopen the issue and change title and description.

Letterus commented 4 years ago

@trunkmaster This applied for a VM on x86_64. So I expect you to run into build issues at some time at the same point as well. I think this should be reopened and release 1.0 should contain libobjc2 2.1.1 or 2.2.

Letterus commented 4 years ago

Please note that building libobjc2 (throwing a warning though) worked well, but linking against libobjc2 of subsequent builds failed at the point mentioned.

trunkmaster commented 4 years ago

@Letterus to make things clearer to me:

  1. Current libobjc2 2.1 has not described issue (warnings) during compilation niether on x86_64 nor on ARM. Is it a correct?
  2. libobjc2 development master branch has issue and hopefully will be fixed in upcoming new release. Correct?

If answers to both questions is "yes" - titled problem is potential issue on libobjc2 version upgrade. Am I right?

Letterus commented 4 years ago

@Letterus to make things clearer to me:

@trunkmaster It's even more complicated:

1. Current libobjc2 2.1 has not described issue (warnings) during compilation niether on x86_64 nor on ARM. Is it a correct?

The bug existed as part of the 2.1 release tarball and was fixed within the 2.1 release tag. It should be fixed with a new 2.1.1 release tarball (or just use the git tag). I expect that issue to affect amd64 as well as ARM.

2. libobjc2 development `master` branch has issue and hopefully will be fixed in upcoming new release. Correct?

No. It's already fixed in master as of https://github.com/gnustep/libobjc2/commit/365e53632e8be41e49f21ee47a63e41be424a237.

If answers to both questions is "yes" - titled problem is potential issue on libobjc2 version upgrade. Am I right?

No. ;-) You will need to upgrade or to use the 2.1 git tag to avoid the bug introduced with the 2.1 tarball.

trunkmaster commented 4 years ago

@Letterus great. Thank you for explanations. Reopening issue.

trunkmaster commented 9 months ago

@Letterus Good news: https://github.com/gnustep/libobjc2/releases/tag/v2.2. I'll plan to change Packaging/Sources scripts first to test new release of libobjc.

trunkmaster commented 5 months ago

I assume that issue was fixed. Please reopen if needed.