search

truongleswe / export-dynamodb

Export Amazon DynamoDb to CSV or JSON
GNU General Public License v3.0
52 stars 9 forks source link

Support for specifying region #8

Closed sarjann closed 5 years ago

sarjann commented 5 years ago

Adds new argument

e.g. -r eu-west-1

I otherwise had errors with the region not specified, if you wish you could specify a default region so someone could choose to not use -r.

truongleswe commented 5 years ago

This shouldn't be an issue if you set it in the aws configuration file which is an assumption of this program. It doesn't support to pass credential or region. It uses whatever is defined in aws/config. Thanks for your suggestion. However, at this point, I'm going to take a not in README.md file and close this PR. We need to add the option for passing both region and credential.

sarjann commented 5 years ago

This shouldn't be an issue if you set it in the aws configuration file which is an assumption of this program. It doesn't support to pass credential or region. It uses whatever is defined in aws/config. Thanks for your suggestion. However, at this point, I'm going to take a not in README.md file and close this PR. We need to add the option for passing both region and credential.

Might this not cause issues if someone uses multiple regions? I could set it to by default use the default credentials in aws/config and if you pass region it will overwrite that?

truongleswe commented 5 years ago

you may have multiple profiles in aws configuration, but each profile should associate to one region. I don't mean that your change isn't good, but I'd like to have it as part of a change which contains passing aws credentials as well.