[Android Bootcamp] Project 1: Photo Viewer - Ready for Review

[truongmm]

My basic app is complete, please review. /cc @codepathreview @codepath

[codepathreview]

Good job completing the required stories but consider adding more optionals so that you can learn more. A few notes after checking out the code:

• Proper usage of sp/dp, margin and relative placement rules
• Consider externalizing string resources for internationalization, even if they're just hint texts. Consider using android:hint instead of android:text as appropriate.
• Consider better organizing your source files
• Consider using the ViewHolder pattern to improve performance of photos ListView.
• Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
• Consider overriding onFailure method in JsonHttpResponseHandler to handle error messages appropriately.

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!

[truongmm]

@codepathreview Can you please elaborate on what you mean by "Proper usage of sp/dp, margin and relative placement rules"? I thought that dp (dimension pixels) is used for margin/padding and sp (scaling pixels) are used for font-sizes? Did I use these incorrectly? And I'm not completely sure what relative placements rules I violated. Can you please give me an example? I tried to place the elements relative to each.

[codepathreview]

@truongmm , the point says "Proper" usage and you have the correct idea of what to use when :+1:

Your layout is correct (just externalize strings/colors/etc).

[truongmm]

@codepathreview I've already addressed the first 4 bullets you gave me! I know it's past the due time, but I'm going to address all the feedback anyways. Thank you for your comments! :)

[codepathreview]

Thanks Melody, really appreciate your agile code update on the feedback given.

Took a quick look, looks good. Keep following the best practices for future assignments.

One more feedback: Consider externalizing the JSON parsing logic to the model class

[truongmm]

@codepathreview Okay! I think I finished addressing all your comments :) Thanks again for the review!

[codepathreview]

Great job @truongmm, hope you can attempt all optional/bonus for the next assignment.