search

truongwp / puppyfw

A powerful options framework for WordPress themes and plugins without coding skills required
https://wordpress.org/plugins/puppyfw/
GNU General Public License v3.0
11 stars 1 forks source link

Add PHP & WP check functions. #5

Closed andyhoanghuu closed 4 years ago

truongwp commented 7 years ago

Hi @ndoublehwp,

  1. PuppyFW requires WordPress version 4.8 and PHP version 5.3.
  2. Please correct typo error: works in to works with, to works to to work.
  3. File puppyfw.php will not be included if you install PuppyFW via composer. Please add version checking code to loader.php file.

This PR is for #4

truongwp commented 7 years ago

It seems ok. But can you squash all commits into one? This can be helpful: https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

andyhoanghuu commented 7 years ago

I'm very sorry for the late delivery. I've fixed conflicts for PR. You can check it again.