tests/conftest.py is not compatible with the newest fido2 library

trussed-dev / fido2-tests

Test suite for FIDO2, U2F, and other security key functions

Other

48 stars 38 forks source link

tests/conftest.py is not compatible with the newest fido2 library #27

Closed tsusanka closed 4 years ago

tsusanka commented 4 years ago

Yubico's python-fido2 0.8.1 release introduced some backwards-incompatible changes and fido2-tests is not compatible with it.

This commit (introduction of the changes) might help https://github.com/Yubico/python-fido2/commit/4c48977173fd32f70e61f518c7624558ffe54b9c.

cc @andrewkozlik

jnaulty commented 4 years ago

For those blocked by this, quick solution is just to lock the requirements.txt to the versions before the breaking change:

diff --git a/requirements.txt b/requirements.txt
index 9fb2dd2..d2c5959 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
-fido2 >=0.7.3
+fido2 >=0.7.3, <0.8
 pyscard
 pytest
 pytest-ordering

prusnak commented 4 years ago

This has been fixed in master here https://github.com/solokeys/fido2-tests/commit/7881689b86a2e9ad5aa9ba2aa9c0747bd406b643