search

trussed-dev / fido2-tests

Test suite for FIDO2, U2F, and other security key functions
Other
48 stars 38 forks source link

Typo report #58

Open ZPHe opened 7 months ago

ZPHe commented 7 months ago

Hi, For short: Two files have typos.

  1. solo_v1.py Ln 11 & 12
    from fido2.ctap1 import CTAP1 from fido2.ctap2 import CTAP2 should be Ctap1 and Ctap2
  2. base.py LN 6 from fido2.ctap2 import CTAP2, CredentialManagement also Ctap2

I followed your document to build the hex file for STM32L432 when using command make build-hacker shows the following message: File "/home/xxxx/.local/lib/python3.12/site-packages/solo/devices/solo_v1.py", line 11, in <module> from fido2.ctap1 import CTAP1 ImportError: cannot import name 'CTAP1' from 'fido2.ctap1' (/home/xxxx/.local/lib/python3.12/site-packages/fido2/ctap1.py). Did you mean: 'Ctap1'? When I solved this Uppercase-lowercase problem, the make command showed no error.

ZPHe commented 7 months ago

I noticed that I may post at the wrong place; please delete my issue or move it to the correct place. Thank you.

Rachad-Alabi-ADEKAMBI commented 7 months ago

Please, I can't locate the files solo_v1.py and base.py

ZPHe commented 7 months ago

Please, I can't locate the files solo_v1.py and base.py

You have to install solo-python first, pip install solo-python

Rachad-Alabi-ADEKAMBI commented 7 months ago

Thank you for your response. I have reviewed it and found the 'base.py' file, but it does not contain the line 'from fido2.ctap2 import CTAP2, CredentialManagement'. Additionally, I am still unable to locate the 'solo_v1.py' file.