trussed-dev / trussed

Modern Cryptographic Firmware
https://trussed.dev
Apache License 2.0
405 stars 26 forks source link

Add nonce to wrap_key and unwrap_key syscalls #148

Closed robin-nitrokey closed 6 months ago

robin-nitrokey commented 6 months ago

This patch adds a nonce argument to the wrap_key and unwrap_key syscalls to be able to use the Aes256Cbc mechanism with a non-zero IV in the future.


I’m not sure if it really makes sense to add the nonce to unwrap_key too. For Aes256Cbc it would be useful, but it currently does not implement unwrap_key anyway. For ChaCha8Poly1305, the encryption result including the nonce is serialized so it does not need to be passed manually by the caller.