search

trussed-dev / usbd-ctaphid

Apache License 2.0
0 stars 3 forks source link

Utilize correct MESSAGE_SIZE #13

Closed KyleKotowick closed 2 months ago

KyleKotowick commented 2 months ago

Prior to commit 1d97873, this value was calculated properly. It was then switched to ctap_types::sizes::REALISTIC_MAX_MESSAGE_SIZE, which was then removed from the ctap_types package, and it was hardcoded at 3072 for an unknown reason in a2104a2.

This PR modifies it back to correctly calculating it as a function of the packet size (giving a max of 7609 with a packet size of 64). The hardcoded 3072 value is insufficient for new post-quantum cryptography algorithms, hence the request to increase it.

KyleKotowick commented 2 months ago

Created off the wrong branch, closing in favor of #14.