trussworks / react-uswds

USWDS 3.0 components built in React
https://trussworks.github.io/react-uswds/
Apache License 2.0
180 stars 81 forks source link

fix: a11y omnibus package #2819

Closed werdnanoslen closed 2 months ago

werdnanoslen commented 6 months ago

Summary

Fixes a bunch of a11y issues that Playwright surfaced (322 of 553 tests failed):

Source changes:

Storybook-only changes:

Related Issues or PRs

Resolves #2811 Resolves #2809

How To Test

If you have Playwright installed locally, run yarn test-storybook. Otherwise, check the Accessibility tab of all the stories

Screenshots (optional)

werdnanoslen commented 6 months ago

~FYI everything is passing checks except for the a11y CI step I added, because it can't run here 🙃 Sooo, maybe we shouldn't run this as a storybook test runner, since it requires a deployed storybook (sorta like how USWDS does it on their PRs). Thoughts on whether to merge this as just a11y updates, with an alternative CI for a11y, or can we still make this work?~

Nvm, I booted it to another branch/PR

kleinschmidtj commented 2 months ago

yarn test-storybook

@werdnanoslen I looked at the code and it looks good to me. I just wanted to run this testing command, but I don't see it the command in package.json. Is this new? Should this have been added as a new script?

werdnanoslen commented 2 months ago

yarn test-storybook

@werdnanoslen I looked at the code and it looks good to me. I just wanted to run this testing command, but I don't see it the command in package.json. Is this new? Should this have been added as a new script?

oh whoops, I'll remove it. I started this ticket by seeing if we should run playwright as a GH task, but I didn't figure out how and pivoted to just fixing the issues it found from running locally.