trussworks / react-uswds

USWDS 3.0 components built in React

https://trussworks.github.io/react-uswds/

Apache License 2.0

182 stars 81 forks source link

fix: Update TextInput ref forwarding #3011

Closed ocoutts-usds closed 1 month ago

ocoutts-usds commented 1 month ago

Summary

Currently this component forwards refs in a way that does not work in new versions of react and I'm not sure if it ever worked in any version of react. Leaving the old way in case somebody is using it.

kimallen commented 1 month ago

Could you add some context in the Summary for what bug this addresses?

brandonlenz commented 1 month ago

Currently this component forwards refs in a way that does not work in new versions of react and I'm not sure if it ever worked in any version of react. Leaving the old way in case somebody is using it.

Yea this might have been a relic from much older versions of react, since I think this was likely one of the first components built for ReactUSWDS

brandonlenz commented 1 month ago

@all-contributors please add ocoutts-usds for bug, code

allcontributors[bot] commented 1 month ago

@brandonlenz

Could not find the user [ocoutts-usds](https://github.com/ocoutts-usds) on github.

brandonlenz commented 1 month ago

@all-contributors please add @ocoutts-usds for bug,code

allcontributors[bot] commented 1 month ago

@brandonlenz

I've put up a pull request to add @ocoutts-usds! :tada: