Continue searching when we get a deleted bucket. Sometimes, ListBuckets will return buckets that have been deleted, but haven't actually been removed yet. This causes GetBucketTagging to return NoSuchBucket, and the function to return without checking any remaining buckets (which could be the one we actually want). This change ensures that when NoSuchBucket is returned, searching will continue.
Copy validated Terraform to /tmp to avoid conflict. Various backward incompatible fixes and improvements for the ValidateAllTerraformModules function:
Always copy Terraform configurations to be validated to a temp directory first to avoid conflicts with tests that do not copy their modules to temp directories
Fix an issue causing FindTerraformModulePathsInRootE to incorrectly return .terraform hidden directories, leading to excess work or possible false positives
For consistency's sake and to avoid an import cycle error when leveraging the CopyTerraformModuleToTemp function, move the ValidateAllTerraformModules function from the terraform package to the test_structure package
Special thanks
Special thanks to the following users for their contribution!
... (truncated)
Commits
eb200a4 Merge pull request #935 from gruntwork-io/validate-all-copy-to-tmp
ebcedc3 Migrate validation tests to test_structure package
924d0da Fix FindAllTerraformModulePathsInRoot and move
3c8132d Copy validated Terraform to /tmp to avoid conflict
a6537d0 Merge pull request #930 from gigyas/fix-finds3bucketwithtag-deleted-bucket
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps github.com/gruntwork-io/terratest from 0.35.6 to 0.36.0.
Release notes
Sourced from github.com/gruntwork-io/terratest's releases.
... (truncated)
Commits
eb200a4Merge pull request #935 from gruntwork-io/validate-all-copy-to-tmpebcedc3Migrate validation tests to test_structure package924d0daFix FindAllTerraformModulePathsInRoot and move3c8132dCopy validated Terraform to /tmp to avoid conflicta6537d0Merge pull request #930 from gigyas/fix-finds3bucketwithtag-deleted-bucketfa6c968Add comment from pr feedbackdff8b51Merge pull request #931 from gruntwork-io/fix-terraform-validation-issues9fa9950Add missing region variable65940a0Pass region instead of Env varf5c6a3fRemove Env strategy for passing regionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)