Add possibility to use multi vendor managed rules

trussworks / terraform-aws-wafv2

Creates a WAF using AWS WAFv2 and AWS Managed Rule Sets

https://registry.terraform.io/modules/trussworks/wafv2

Apache License 2.0

103 stars 58 forks source link

Add possibility to use multi vendor managed rules #77

Closed fdmsantos closed 1 year ago

fdmsantos commented 3 years ago

Problem

I need add managed rules from F5 vendor This module only accepts AWs Managed Rules

Solution

Add vendor_name attribute to managed_rules variables

Considerations

This PR have breaking changes. With this PR, the vendor_name attribute is required, and this attribute doesn't exist in module.

I can change the code to this vendor_name attribute be optional, but for this i need to use the follow experimental feature: Optional Object Type Attributes

rpdelaney commented 2 years ago

Hello! Sorry for the slow turn-around: we're trying to step up our game with managing external PRs. Is this still needed?