search

trussworks / terraform-aws-wafv2

Creates a WAF using AWS WAFv2 and AWS Managed Rule Sets
https://registry.terraform.io/modules/trussworks/wafv2
Apache License 2.0
103 stars 58 forks source link

Support Custom Response status code and headers on block action #86

Closed aairey closed 1 year ago

aairey commented 2 years ago

The terraform resource supports it already, please update the module to support it as well.

https://github.com/hashicorp/terraform-provider-aws/issues/18754

rpdelaney commented 2 years ago

Hello @aairey ! Just to make sure we understand, you want an input variable that will pass-through to the custom_response_body block described here. Is that right?

aairey commented 2 years ago

Correct!

rpdelaney commented 2 years ago

Ok, got it. That seems like something we'd like to support. I'll add it to our roadmap for engineers not on client projects to take on; in the mean time, I'd be happy to review a PR :)

rpdelaney commented 2 years ago

I'm not seeing support in this module for a custom_response field. I think that may have to be added as well.

rpdelaney commented 1 year ago

@aairey We recognize the value of this, but it's not something we need at the moment. If you can send us a PR we'll be happy to take a look :)

xgt001 commented 1 year ago

hi @rpdelaney , would you be interested in accepting my PR. If this is something you can see being accepted, I am happy to refine it and complete this piece by adding support to JSON and HTTP response bodies , as well as adding support for multiple response bodies