trussworks / terraform-aws-wafv2

Creates a WAF using AWS WAFv2 and AWS Managed Rule Sets
https://registry.terraform.io/modules/trussworks/wafv2
Apache License 2.0
104 stars 58 forks source link

Make search_string configurable for filtered_header_rule #97

Closed neilharris123 closed 1 year ago

neilharris123 commented 2 years ago

Currently the search_string for filtered_header_rules must have the same value as the rule name. If the search string is a header value that is sensitive, the only way with the existing module to add it as the search string, is to use the name of the rule. I don't believe having the same value for rule name and and search string makes sense in most cases. This change preserves the previous behaviour, but allows user to set their own search_string.

rpdelaney commented 1 year ago

Shipped in v2.6.0