codecov[bot]
commented
2 years ago Codecov Report
Merging #420 (fc1c0f7) into main (9b18f7e) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 14 14
Lines 1249 1249
=======================================
Hits 1087 1087
Misses 101 101
Partials 61 61 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does seem to work fine on arm64 Mac OS currently, presumably due to Apple's Rosetta translation layer or some other emulation layer).
Signed-off-by: Derek Trider Derek.Trider@securekey.com