search

trustbloc / edge-core

Shared libraries
Apache License 2.0
2 stars 13 forks source link

fix: Incorrect error handling when GetBulk argument is nil #126

Closed DRK3 closed 3 years ago

DRK3 commented 3 years ago

Passing nil into the GetBulk function would result in an unexpected error (in the case of CouchDB store), or no error at all (in the case of memstore). This fixes that.

Signed-off-by: Derek Trider Derek.Trider@securekey.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #126 (be0275a) into master (901584a) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   86.68%   86.72%   +0.03%     
==========================================
  Files          25       25              
  Lines        1450     1454       +4     
==========================================
+ Hits         1257     1261       +4     
  Misses        117      117              
  Partials       76       76
Impacted Files Coverage Δ
pkg/storage/couchdb/couchdbstore.go 84.52% <100.00%> (+0.09%) :arrow_up:
pkg/storage/memstore/memstore.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 901584a...be0275a. Read the comment docs.