search

trustbloc / edv

Encrypted data vault implementation in Golang - https://identity.foundation/edv-spec/
Apache License 2.0
16 stars 17 forks source link

refactor: zcapld caching logic #186

Closed aholovko closed 3 years ago

aholovko commented 3 years ago

This PR replaces CachedLDDocs with JSON-LD DocumentLoader that is initialized only once and is backed by verifiable.CachingJSONLDLoader() with pre-loaded contexts. It also updates AFG to the latest version.

Signed-off-by: Andriy Holovko andriy.holovko@gmail.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #186 (487f664) into main (ddab472) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   85.56%   85.68%   +0.12%     
==========================================
  Files          14       14              
  Lines        1690     1663      -27     
==========================================
- Hits         1446     1425      -21     
+ Misses        153      150       -3     
+ Partials       91       88       -3
Impacted Files Coverage Δ
cmd/edv-rest/startcmd/start.go 83.28% <100.00%> (ø)
pkg/auth/zcapld/service.go 81.60% <100.00%> (+0.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddab472...487f664. Read the comment docs.

aholovko commented 3 years ago

@Baha-sk I updated ECDH256KWAES256GCMType to NISTP256ECDHKW in BDD tests. Please let me know if this is not the type of key that we want.

baha-ai commented 3 years ago

@Baha-sk I updated ECDH256KWAES256GCMType to NISTP256ECDHKW in BDD tests. Please let me know if this is not the type of key that we want.

@aholovko I didn't know you had to update EDV, I've pushed an update PR for AFG updated revision, can you rebase?