Closed baha-ai closed 3 years ago
Merging #205 (44c3068) into main (6bd046b) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 85.27% 85.27%
=======================================
Files 14 14
Lines 1630 1630
=======================================
Hits 1390 1390
Misses 149 149
Partials 91 91
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6bd046b...44c3068. Read the comment docs.
@Baha-sk do we need to change this https://github.com/trustbloc/edv/blob/main/pkg/auth/zcapld/service.go#L118
@fqutishat as long as we create the loader using verifiable.CachingJSONLDLoader()
here:
https://github.com/trustbloc/edv/blob/main/cmd/edv-rest/startcmd/start.go#L623
Nothing else needs to be changed. The edv service creation and handler setup (including the line you mentioned above) is instantiated during the start of the edv-rest command.
AFG has been updated to load the framework's cache document loader in verifiable.CachingJSONLDLoader()
.
Signed-off-by: Baha Shaaban baha.shaaban@securekey.com