search

trustbloc / edv

Encrypted data vault implementation in Golang - https://identity.foundation/edv-spec/
Apache License 2.0
16 stars 17 forks source link

fix: TLS certs command line parameter handling #259

Closed DRK3 closed 2 years ago

DRK3 commented 2 years ago

Previously, the TLS certs command line parameter and env var equivalent had different formats: the command line flags had to be repeated, while the env var used comma separated values. This was confusing since the documentation simply says that it's supposed to be in CSV format, but if you tried that with the command line flag then it wouldn't work as expected. Using a new method I added to edge-core, now both method work the same way.

Also used this new method to simplify the logic for the auth-type flag/env var.

Signed-off-by: Derek Trider Derek.Trider@securekey.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #259 (88814b6) into main (32504d2) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   85.35%   85.42%   +0.06%     
==========================================
  Files          13       13              
  Lines        1755     1749       -6     
==========================================
- Hits         1498     1494       -4     
+ Misses        157      156       -1     
+ Partials      100       99       -1
Impacted Files Coverage Δ
cmd/edv-rest/startcmd/start.go 82.57% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32504d2...88814b6. Read the comment docs.