trustbloc / edv

Encrypted data vault implementation in Golang - https://identity.foundation/edv-spec/
Apache License 2.0
16 stars 17 forks source link

feat: More robust auth header handling #260

Closed DRK3 closed 2 years ago

DRK3 commented 2 years ago

Updated the code that accesses headers containing GNAP or ZCAP auth data to be more robust. It now checks all possible header values instead of only the first one and the code now uses the built-in Header methods to access the header values, which ensures that they are canonicalized.

Signed-off-by: Derek Trider Derek.Trider@securekey.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #260 (1cc74a5) into main (93f74af) will increase coverage by 0.01%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   85.42%   85.43%   +0.01%     
==========================================
  Files          13       13              
  Lines        1749     1758       +9     
==========================================
+ Hits         1494     1502       +8     
- Misses        156      157       +1     
  Partials       99       99              
Impacted Files Coverage Δ
cmd/edv-rest/startcmd/start.go 82.67% <93.75%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93f74af...1cc74a5. Read the comment docs.