trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

fix(sdk): Update linter #558

Closed DRK3 closed 1 year ago

DRK3 commented 1 year ago

Some new dependencies from aries-framework-go that we will need have some incompatibilities with the older linter version we're using. Updating the linter fixes this. This commit also updates code to comply with new rules in the linter (except for depguard, which has been added to the list of exceptions for now as it requires more consideration).

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (a2acdb0) 90.07% compared to head (dac9189) 90.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #558 +/- ## ======================================= Coverage 90.07% 90.07% ======================================= Files 98 98 Lines 3797 3797 ======================================= Hits 3420 3420 Misses 250 250 Partials 127 127 ``` | [Files Changed](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc) | Coverage Δ | | |---|---|---| | [cmd/wallet-sdk-gomobile/localkms/localkms.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvbG9jYWxrbXMvbG9jYWxrbXMuZ28=) | `69.44% <0.00%> (ø)` | | | [...k-gomobile/openid4ci/issuerinitiatedinteraction.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvb3BlbmlkNGNpL2lzc3VlcmluaXRpYXRlZGludGVyYWN0aW9uLmdv) | `88.17% <ø> (ø)` | | | [...k-gomobile/openid4ci/walletinitiatedinteraction.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvb3BlbmlkNGNpL3dhbGxldGluaXRpYXRlZGludGVyYWN0aW9uLmdv) | `75.40% <ø> (ø)` | | | [pkg/openid4vp/openid4vp.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL29wZW5pZDR2cC9vcGVuaWQ0dnAuZ28=) | `94.10% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication