search

trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

fix(app): Connect issuer page UI Display #562

Closed talwinder50 closed 1 year ago

talwinder50 commented 1 year ago
talwinder50 commented 1 year ago

@DRK3 @rolsonquadras As we discussed, we were thinking it's not appropriate to make a backend call to launch the issuer display, as current method to fetch the issuer metadata is attached to interaction. However, currently we are only initiating the interaction object after user clicks CONNECT not before that. If we need to leverage to make the backend call we would need to expose an API to fetch the issuer metadata without being tied to interaction.

As per user experience, it doesn't make sense to depend this feature on backend call. Earlier the walletintiatedconfig was added to add theme display features as well in the config.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8769f78) 90.63% compared to head (bc1e029) 90.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #562 +/- ## ======================================= Coverage 90.63% 90.63% ======================================= Files 99 99 Lines 4067 4067 ======================================= Hits 3686 3686 Misses 253 253 Partials 128 128 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.