trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

fix(app): fixed data handling logic in verification flow for web #590

Closed birtony closed 1 year ago

birtony commented 1 year ago

Signed-off-by: Anton Biriukov anton.biriukov@gendigital.com

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (6caf401) 89.98% compared to head (0e94686) 89.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #590 +/- ## ======================================= Coverage 89.98% 89.98% ======================================= Files 98 98 Lines 3896 3896 ======================================= Hits 3506 3506 Misses 258 258 Partials 132 132 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

birtony commented 1 year ago

Hi did we tested the change in the app ? So we removed the stored credential while presenting credential now ?

Hey @talwinder50 ! Yes, I tested on web and on iOS as well. The parameter you're talking about was passed down but never actually used in the web logic, so I dropped it. cc @DRK3

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information