trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

fix(app): Removing error check "UKN2-000" while handling redirect uri #607

Closed talwinder50 closed 1 year ago

talwinder50 commented 1 year ago

This change avoid keep listening to all created subscription stream and hence no longer throw UKN2-200 data not found error so we don't need that ugly error check anymore.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.10% :warning:

Comparison is base (3abc2fe) 89.83% compared to head (e4351ec) 89.74%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #607 +/- ## ========================================== - Coverage 89.83% 89.74% -0.10% ========================================== Files 98 101 +3 Lines 3927 3980 +53 ========================================== + Hits 3528 3572 +44 - Misses 265 272 +7 - Partials 134 136 +2 ``` | [Files Changed](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc) | Coverage Δ | | |---|---|---| | [cmd/wallet-sdk-gomobile/didjwk/didjwk.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvZGlkandrL2RpZGp3ay5nbw==) | `81.81% <81.81%> (ø)` | | | [cmd/wallet-sdk-gomobile/didkey/didkey.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvZGlka2V5L2RpZGtleS5nbw==) | `81.81% <81.81%> (ø)` | | | [pkg/did/creator/jwk/jwk.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL2RpZC9jcmVhdG9yL2p3ay9qd2suZ28=) | `100.00% <100.00%> (ø)` | | | [pkg/did/creator/key/key.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL2RpZC9jcmVhdG9yL2tleS9rZXkuZ28=) | `77.27% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information