trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

feat(app): Add support for DI proofs #614

Closed talwinder50 closed 1 year ago

talwinder50 commented 1 year ago

Signed-off-by: Talwinder kaur talwinder.kaur@avast.com

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1217a1e) 89.74% compared to head (54d9491) 89.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ======================================= Coverage 89.74% 89.74% ======================================= Files 101 101 Lines 3980 3980 ======================================= Hits 3572 3572 Misses 272 272 Partials 136 136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DRK3 commented 1 year ago

Typo in the commit title: it says andoird instead of android.

It's also missing the word "apps" at the end of the message, which is a bit confusing - support was added in the ios and android...what?

My suggestion to address that and avoid running over the character limit would be a message similar to the following:

feat(app): Add support for DI proofs

(see how it's much shorter now, and also the "app" part at the beginning means you don't really need to specify it again later in the message)

DRK3 commented 1 year ago

Also, don't forget to update the commit message too.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information