trustbloc / wallet-sdk

Verifiable Credential Wallet SDK and Demo/Reference Wallet App (Go / GoMobile | Android | iOS)
Apache License 2.0
21 stars 13 forks source link

refactor(sdk): use kms-go Suite instead of kms and crypto APIs #634

Closed Moopli closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0f4fd97) 89.67% compared to head (db2779b) 89.23%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #634 +/- ## ========================================== - Coverage 89.67% 89.23% -0.45% ========================================== Files 102 102 Lines 4069 4060 -9 ========================================== - Hits 3649 3623 -26 - Misses 280 298 +18 + Partials 140 139 -1 ``` | [Files](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc) | Coverage Δ | | |---|---|---| | [cmd/wallet-sdk-gomobile/openid4vp/interaction.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-Y21kL3dhbGxldC1zZGstZ29tb2JpbGUvb3BlbmlkNHZwL2ludGVyYWN0aW9uLmdv) | `81.63% <100.00%> (+0.78%)` | :arrow_up: | | [pkg/localkms/ariescryptowrapper.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL2xvY2Fsa21zL2FyaWVzY3J5cHRvd3JhcHBlci5nbw==) | `100.00% <100.00%> (ø)` | | | [pkg/localkms/localkms.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL2xvY2Fsa21zL2xvY2Fsa21zLmdv) | `82.60% <100.00%> (-2.58%)` | :arrow_down: | | [pkg/localkms/provider.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL2xvY2Fsa21zL3Byb3ZpZGVyLmdv) | `76.92% <ø> (-5.43%)` | :arrow_down: | | [pkg/openid4vp/openid4vp.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL29wZW5pZDR2cC9vcGVuaWQ0dnAuZ28=) | `91.28% <100.00%> (-0.07%)` | :arrow_down: | | [pkg/openid4vp/opts.go](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc#diff-cGtnL29wZW5pZDR2cC9vcHRzLmdv) | `77.77% <50.00%> (+2.77%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/trustbloc/wallet-sdk/pull/634/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trustbloc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
7.0% 7.0% Duplication