search

trustcrypto / OnlyKey-App

The OnlyKey App is used for the initial setup and configuration of OnlyKey. Supported on Windows, macOS, Linux, and Chromebook (with Chrome App).
https://docs.crp.to/app.html
Other
106 stars 24 forks source link

bug in scripts/external-links.js: `evt.stopPropagation()` will never be called #177

Closed mmiller42 closed 2 years ago

mmiller42 commented 2 years ago

See:

https://github.com/trustcrypto/OnlyKey-App/blob/feeb58ca9ff3e3c7f48026bfc43519d383fccfea/app/scripts/external-links.js#L12

    cancelDefault && evt.preventDefault() && evt.stopPropagation();

Event.prototype.preventDefault() returns undefined, so the short-circuit of this expression will never reach evt.stopPropagation().