trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
212 stars 40 forks source link

Intermitent return after removing "Return after Password" from slot #128

Closed 0x4161726f6e closed 2 years ago

0x4161726f6e commented 2 years ago

Password gets type every other time with [return] after re-setting password without "Return after Password" set.

onlykey commented 2 years ago

Can you give some steps to try and reproduce this issue?

0x4161726f6e commented 2 years ago
  1. Set a password on any slot selecting "return after password"
  2. reset the same password with "return after password" unselected
  3. TEST: output password to any plain text editor at least 5 times in a row row

Note I have also found an inconsistent return issue in when onlykey types out slot labels

onlykey commented 2 years ago

When filling out the form to set data to OnlyKey the only fields that are set are those which have the box checked. So in your example, you would not have changed the return after password setting, it would still be set.

To not have return after password select the none radio button image

0x4161726f6e commented 2 years ago

Sorry I wasn't explicit, but for both steps 1 & 2 the Password checkbox is checked.

onlykey commented 2 years ago

Right but you have with "return after password" unselected. Unselected means it will still do Return after password because unselected means make no changes to current settings. You have to select "None"