trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
212 stars 40 forks source link

Labels not get displayed correctly #149

Closed bryanpedini closed 1 year ago

bryanpedini commented 1 year ago

It seems that sometimes the labels do not get displayed correctly. I observed the following behavior after immediately restoring a backup I just finished performing (I was doing some tests with FIDO PIN and stuff via CLI): Screenshot_20220716_165426

Perhaps the app is expecting the labels to start at byte X of return messages while the key outputs the labels starting at byte Y?

Related: https://github.com/trustcrypto/OnlyKey-App/issues/201 https://github.com/trustcrypto/python-onlykey/issues/66 (either there's an issue with both the app and the CLI (or the app underlying uses the CLI), or there's something in the firmware... tho I'm not qualified nor expert enough to determine. Feel free to close the issues where they're not relevant)