trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
212 stars 40 forks source link

Keymap for ^ on GERMAN_MAC #157

Open Piggeldi2013 opened 1 year ago

Piggeldi2013 commented 1 year ago

The keymap for the ^ sign on Keyboard Layout GEMAN_MAC doesn't seem to work correctly.

If used in a password, the ^ sign is replaced with a space.

This seems to be the only thing that isn't working in the keymap.

So, given a password of: asd^dde results in: asd dde

Setting of the password has been tested with the App and also on command line - with same results.

Please advise.

onlykey commented 1 year ago

@Piggeldi2013 Can you use the app here and let us know what keycode you are getting when you type ^ with your keyboard and then what keycode you get when OnlyKey types this?

https://apps.apple.com/us/app/key-codes/id414568915?mt=12

Piggeldi2013 commented 1 year ago
image

Same for both - adding it in the App, and also with cli.

onlykey commented 1 year ago

No I mean if you type the ^ character via your keyboard like this: image

Then 2nd screenshot of if OnlyKey types the ^ character (set your password as this in a slot for the test, then press button on your onlykey to type)

Piggeldi2013 commented 1 year ago

Thanks for coming back.

The key (pressed at keyboard) is:

image

And the image in my post before shows how the "password" is sent by the OnlyKey.

onlykey commented 1 year ago

Can you send the whole thing like, type "^ ^" via keyboard and OnlyKey like this:

^ ^ typed on keyboard: image

^ ^ typed via OnlyKey image

Piggeldi2013 commented 1 year ago

Sure I can - here the screens for ^ ^

Keyboard:

image

OnlyKey:

image
onlykey commented 1 year ago

@Piggeldi2013 Oh sorry it looks like you don't have the "Log key up events and modifier changes" box checked, can you send the same results again with that box checked?

Piggeldi2013 commented 1 year ago

Hi, no problem - I'm glad that I get help and can give some more infos - thanks for that!!

Keyboard:

image

OnlyKey:

image
Piggeldi2013 commented 1 year ago

Any news on that? Something I can help or provide?

onlykey commented 1 year ago

@Piggeldi2013 No, thank you for the help. It looks like we can generate the ^ character using the combination of SHIFT+ALT+6

We will get this change into the next release

onlykey commented 1 year ago

@Piggeldi2013 Can you please test the firmware here? I believe the issue is fixed now. Signed_OnlyKey_3_0_4_STD.txt