trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
212 stars 40 forks source link

Text display issue and incorrect text on Onlykey App SETUP tab #165

Open SmartlyCautionMaybe opened 10 months ago

SmartlyCautionMaybe commented 10 months ago

ENVIRONMENT: Onlykey app 5.5.0, installed via .deb OS: Linux Mint 21.1 (vera) Used with: OnlyKey v3.0.4-prodc

ISSUE: The OnlyKey App SETUP tab text displays as shown in the attached screenshot:

onlykey 5_5_0 setup tab

However, if you copy and paste that text block elsewhere, it shows the following content:

"Before selecting an option below, you must first put your OnlyKeyDUO into config mode. To do this hold down button #6 on your OnlyKey for 5+ seconds and release. hold down button #1 on your OnlyKey DUO for 10+ seconds and release.The light will turn off. If a PIN was previously set, re-enter the PIN to enter config mode.You will notice the OnlyKey flashes red in config mode."

RECOMMENDED CHANGE:

  1. Fix formatting so correct text is displayed
  2. Correct inconsistencies between OnlyKEY and OnlyKey DUO
  3. Fix capitalization typo ("... and release. Hold down Button 1 ..."

Potential replacement text (I cannot confirm this is correct for the OnlyKey DUO):

"Before selecting an option below, you must first put your OnlyKey or OnlyKey DUO into config mode. To do this,

The light will turn off. If a PIN was previously set, re-enter the PIN to enter config mode. You will notice the OnlyKey or Onlykey Duo flashes red in config mode."

Thanks.

IGLOU-EU commented 5 months ago

Hi, this is probably an application issue and not a firmware one