trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
219 stars 40 forks source link

OKWIPESLOT does not wipe slot. #5

Closed rodgolpe closed 8 years ago

rodgolpe commented 8 years ago

When the Chrome app sends OKWIPESLOT, slot data still seems to be set. Pressing a "wiped" slot button continues to output usernames and passwords.

Serial Monitor shows: Received packetFFFFFFFFE710000000000000000000000000000000000000000000000000000000000OKWIPESLOT MESSAGE RECEIVED:67 Wiping Slot #1 Value #0 000000000000000000000000000000000000000000000000000000000Overwriting slot with 0s

onlykey commented 8 years ago

It was looking for value 0 which does not exist. Since wipe slot wipes the whole slot and not just certain fields it was an easy fix.