search

trustcrypto / OnlyKey-Firmware

The OnlyKey Firmware runs on the OnlyKey itself and provides the core functionality of OnlyKey.
https://docs.crp.to/firmware.html
212 stars 40 forks source link

Issue: Enter after OTP enabled on all profiles after restoring config #73

Closed japtain-cack closed 5 years ago

japtain-cack commented 6 years ago

Just bought another OnlyKey to create a clone of my existing one. After I updated to the latest firmware and restored the config, I noticed that every time I pressed a button the password would have a carriage return after it. Disabling the "return after password" had no effect. That's when I noticed the "return after OTP" was enabled, odd...

Anyway, I went back to my original OnlyKey and ensured this setting was off on applicable profiles, toggled it on/back off, did another backup and restore to the new OnlyKey and it happened again. Then I did a firmware upgrade on my original OnlyKey and after the restore, "return after OTP" was enabled on all profiles. Profiles with "return after password" actually had two carriage returns after the password.

After setting "return after OTP" off on all necessary profiles, enabling or disabling "return after password" on the desired profiles, everything is working as expected.

Conclusion: After restoring a config, "return after OTP" is causing an extra carriage return after every entry. This did not happen on the previous firmware.

onlykey commented 5 years ago

@Jedimaster0 Addressed in latest desktop app release