search

trusteddomainproject / OpenARC

Open source ARC implementation
BSD 2-Clause "Simplified" License
135 stars 45 forks source link

Add human readable name of chain state to info message. #138

Closed minfrin closed 2 years ago

minfrin commented 3 years ago

The message "chain state forced to 1 due to prior result found" contains an internal enum index rather than the name of the chain state. Replace with the human readable meaning.

flowerysong commented 3 years ago

I feel like it would be cleaner to expose and reuse the existing mechanism in libopenarc for doing this translation (see e.g. https://github.com/trusteddomainproject/OpenARC/blob/eb430dbdeee9f502295fe7a7d5041dfca3f00745/libopenarc/arc.c#L3666)

minfrin commented 3 years ago

Can you take a look at the updated patch?

flowerysong commented 3 years ago

Ah, yeah, that's even better.

minfrin commented 3 years ago

Thanks for this.

minfrin commented 3 years ago

Quick ping on this, any news?

minfrin commented 2 years ago

@flowerysong Would it be possible to merge this one?

glts commented 2 years ago

@minfrin Note that the patch should not be merged as-is because it is out of sync with the development branch.

The pull request must target the develop branch, not master. And then it must be updated in order to compile, eg as done here: https://sources.debian.org/patches/openarc/1.0.0%7Ebeta3+dfsg-1%7Eexp1/chain-state-name.patch/

(I have no info on the status of the project though, it seems abandoned.)

flowerysong commented 2 years ago

@minfrin This project has been dead for years, unfortunately. I optimistically believed @martinbogo's claim that the project was alive again (https://github.com/trusteddomainproject/OpenARC/issues/123#issuecomment-644220261) but that was clearly just an attempt to placate people and not an actual commitment to expend even the slightest effort on it.

minfrin commented 2 years ago

@minfrin Note that the patch should not be merged as-is because it is out of sync with the development branch.

The pull request must target the develop branch, not master. And then it must be updated in order to compile, eg as done here: https://sources.debian.org/patches/openarc/1.0.0%7Ebeta3+dfsg-1%7Eexp1/chain-state-name.patch/

(I have no info on the status of the project though, it seems abandoned.)

Getting back to this one.

Replaced this PR with a new one: https://github.com/trusteddomainproject/OpenARC/pull/158

minfrin commented 2 years ago

@minfrin This project has been dead for years, unfortunately. I optimistically believed @martinbogo's claim that the project was alive again (#123 (comment)) but that was clearly just an attempt to placate people and not an actual commitment to expend even the slightest effort on it.

I'm happy to submit patches, are there people willing to review them?